microsoft / microsoft/TypeScript

No excess property error for computed property

Open
#36,920 7 comments 7 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

In Discussion Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.7.5 and 3.9.0-dev.20200220

Search Terms: excess property, computed property, index signature

Code

interface Foo {
	a: string;
} 

const bar: Foo = {
	a: "",
	z: "" // error, excess prop
}

const baz: Foo = {
	a: "",
	["Z".toLowerCase()]: "" // this is okay I guess?
}

Expected behavior:
The computed property in the definition of baz should maybe produce an excess property error, since Foo has no string index signature and "Z".toLowerCase() is only known to be a string.

Actual behavior:
The computed property is allowed.

Playground Link: Here

Related Issues: #22427

This issue is a re-opening of #22427, which was marked as a bug and closed as "fixed", but I don't see an actual fix referenced anywhere in that issue and the behavior described in that issue persists. Any ideas? Thanks!

There's an SO question asking this, which brought me to #22427, which has me scratching my head 😕.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the TypeScript playground reproduction in the issue and compare the computed-property case with the direct excess-property case. Read related issue #22427 to understand the prior discussion; done means the expected excess-property behavior is resolved or the intended behavior is documented by updated compiler tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.