microsoft / microsoft/TypeScript
Support symbol properties on namespaces
Open
Nobody has claimed this yet.
In Discussion
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Search Terms
- namespace symbol
- namespace symbol property
- namespace symbol properties
Suggestion
The ability to declare symbol properties on TypeScript namespaces.
Use Cases
See https://github.com/DefinitelyTyped/DefinitelyTyped/pull/42154#discussion_r376739320.
Examples
// doSomething.d.ts
import { promisify } from "util";
declare function doSomething(
foo: any,
onSuccessCallback: (result: string) => void,
onErrorCallback: (reason: any) => void
);
declare namespace doSomething {
function [promisify.custom](foo: any): Promise<string>;
}
export = doSomething;
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the example declaration in doSomething.d.ts and the linked DefinitelyTyped discussion first; the payload names no compiler files or tests. Done means the requested symbol property on a namespace is accepted while preserving the stated declaration and runtime constraints.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100