microsoft / microsoft/TypeScript

Ensure generated `.d.ts` files compile with no errors under `noImplicitAny`

Open
#36,639 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Domain: Declaration Emit Infrastructure
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

We recently just had https://github.com/microsoft/TypeScript/issues/36630 opened up on us. This is just a few weeks after #36216.

I'm pretty sure we already check that our generated .d.ts files are valid when the input was valid, but apparently we're not checking under noImplicitAny. We would've avoided these bugs if we'd checked with noImplicitAny.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing checks for generated .d.ts files and how they validate declarations from valid input. Add coverage for compilation with noImplicitAny enabled; done means generated declarations from valid input compile without errors under that option.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.