microsoft / microsoft/TypeScript
Performance regression in #33473
Open
@weswigham is already working on this.
Since Nov 3, 2021.
Domain: Performance
Needs Investigation
Rescheduled
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
The extra work done in #33473 is valuable, but maybe it doesn't need to be so expensive. In this particular case, there don't seem to be any errors (though there is one @ts-ignore).
Setup:
- Clone https://github.com/amcasey/material-ui.git
- Check out Benchmark
yarnto restore packagesyarn typescriptto prebuild and run some TS tests
Repro
tsc -p docs
On a random Mac Mini:
- 10-run avg on https://github.com/microsoft/TypeScript/commit/6c2ae12559508b594f7038f8d6165b92ec89c58c: 33,010ms
- 10-run avg on https://github.com/microsoft/TypeScript/commit/26caa3793e310e271ddee8adc1804486e5b0749f: 33,494ms (1% slower)
Note: to build old TS commits, you probably need to change const { default: chalk } to const chalk in scripts/build/utils.js.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.