microsoft / microsoft/TypeScript

Issue errors on tslib version ranges in `package.json`

Open
#35,927 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Needs Proposal Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Similar in spirit to https://github.com/microsoft/TypeScript/issues/33603

@bterlson and friends on the Azure SDK team mentioned that there was an issue with tslib where a local installation might grab tslib@1.10.x, but could have issues in other environments because their package.json specified a minimum version (1.9.x) which was too old.

I don't think that we generally dive into package.json to issue errors, but this seemed pretty unexpected, and it leads to more obvious behavior than with issuing errors about missing exports.

On the other hand, this might be a problem for slightly more esoteric but legitimate use-cases like alternate implementations/sources of tslib. For example, a user could point tslib at a local folder or a GitHub URL.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names package.json and tslib but no source file or test. Start by reading TypeScript issue #33603 and locating the existing package-resolution diagnostics; clarify whether version-range errors should preserve alternate tslib sources, then define tests for the accepted behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.