microsoft / microsoft/TypeScript
commonjs export binding not updated in ForInOrOfStatement
Open
Nobody has claimed this yet.
Bug
Domain: JS Emit
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 3.7.2
Search Terms: commonjs export for of
Code
// @module: commonjs
// @target: esnext
let foo = '';
export { foo };
for (foo in {}) { }
for (foo of []) {}
for ({foo} of [{foo}]) {}
Expected behavior:
for...in and for...of should update the export binding.
for (_a in {}) {
exports.foo = foo = _a;
}
for (_b of []) {
exports.foo = foo = _b;
}
for (_c of [{foo}]) {
exports.foo = foo = _c.foo;
}
Actual behavior:
Binding is not updated
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with the provided TypeScript code using CommonJS and ESNext settings, then inspect the emitted JavaScript for each for-in and for-of form. Trace the compiler's handling of export bindings in these loop forms and verify that the generated output updates exports.foo as shown.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100