microsoft / microsoft/TypeScript

commonjs export binding not updated in ForInOrOfStatement

Open
#35,881 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Domain: JS Emit
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.7.2

Search Terms: commonjs export for of

Code

// @module: commonjs
// @target: esnext
let foo = '';
export { foo };
for (foo in {}) { }
for (foo of []) {}
for ({foo} of [{foo}]) {}

Expected behavior:

for...in and for...of should update the export binding.

for (_a in {}) { 
  exports.foo = foo = _a;
}
for (_b of []) {
  exports.foo = foo = _b;
}
for (_c of [{foo}]) {
  exports.foo = foo = _c.foo;
}

Actual behavior:

Binding is not updated

Playground Link: https://www.typescriptlang.org/play/?target=99&module=1#code/DYUwLgBAZg9jEF4IHJkG4BQIAeAHGATpAN7RwQC+msBEAFLPAJYB2ExFAlO5RjfYwgwoEANoBdbhz6F6xRhSEjR8uBUnsKQA

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the provided TypeScript code using CommonJS and ESNext settings, then inspect the emitted JavaScript for each for-in and for-of form. Trace the compiler's handling of export bindings in these loop forms and verify that the generated output updates exports.foo as shown.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.