microsoft / microsoft/TypeScript

Named imports should respect Record<string, any> types

Open
#35,827 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Domain: ES Modules
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.7.x-dev.201xxxxx

Search Terms: dynamic named imports, commonjs named imports

Code

declare module '*.wasm' {
  type WasmProxy = Record<string, (...args: any[]) => Promise<any>>;
  const wasmProxy: WasmProxy;
  export = wasmProxy;
}

Expected behaviour:

I would expect typescript to allow any named import such as:

import {anything, hello, hola } from './program.wasm';

Since the exported namespace is a Record, where any string is valid.

Actual behavior:

The following code does NOT work:

// Does not work
import {anything, hello, hola } from './program.wasm';

Using the wildcard import works:

// Does work
import * as ns from './program.wasm';
ns.anything;
ns.hello;
ns.hola;

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the provided TypeScript reproducer for a wildcard module exporting Record<string, (...args: any[]) => Promise> and compare named-import checking with namespace access. Done means arbitrary named imports such as anything, hello, and hola are accepted for the declared .wasm module while the existing wildcard behavior remains valid.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.