microsoft / microsoft/TypeScript
Add a new helper type `Primitive` for JSON
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Search Terms
- Primitive
- JSON
Suggestion
When you encode an object to a JSON-string and decode the JSON-string to an object again, the object would be primitive. All of the methods defined in the object would be removed and its prototype would also be the primitive Object.
If the target object has a
toJSON()method, it would be converted to a pritimive of returned value from thetoJSON()method.
To express those conversions, I suggest a new helper type Primitive. I believe that providing the helper type Primitive is much better choice rather than hard-coding; enforcing programmers to implement duplicated (primitive) type definition, by themselves, considering the JSON encoding & decoding.
Below is the implementation code:
/**
* Primitify a type.
*
* If target type is an object, all methods defined in the object would be
* removed. Also, if the target type has a `toJSON()` method, its return type
* would be chosen.
*
* @typeParam T A type to be primitive
*/
export type Primitive<Instance> = value_of<Instance> extends object
? Instance extends object
? Instance extends IJsonable<infer Raw>
? value_of<Raw> extends object
? Raw extends object
? PrimitiveObject<Raw> // object would be primitified
: never // cannot be
: value_of<Raw> // atomic value
: PrimitiveObject<Instance> // object would be primitified
: never // cannot be
: value_of<Instance>;
/**
* @hidden
*/
type PrimitiveObject<Instance extends object> =
{
[P in keyof Instance]: Instance[P] extends Function
? never
: Primitive<Instance[P]>
};
/**
* @hidden
*/
type value_of<Instance> =
is_value_of<Instance, Boolean> extends true ? boolean
: is_value_of<Instance, Number> extends true ? number
: is_value_of<Instance, String> extends true ? string
: Instance;
/**
* @hidden
*/
type is_value_of<Instance, Object extends IValueOf<any>> =
Instance extends Object
? Object extends IValueOf<infer Primitive>
? Instance extends Primitive
? false
: true // not Primitive, but Object
: false // cannot be
: false;
/**
* @hidden
*/
interface IValueOf<T>
{
valueOf(): T;
}
Use Cases
interface IMember
{
id: Number;
name: string;
email: String;
mobile: string;
login_histories: LoginHistory[];
}
declare class Member
{
private id_: Number;
private name_: string;
private email_: String;
private mobile_: string;
private login_histories_: LoginHistory[];
public activate(password: string): boolean;
public isActivated(): boolean;
public toJSON(): IMember;
}
declare class LoginHistory
{
public readonly timestamp: Date;
public readonly success: Boolean;
}
function main(json: string): void
{
// Member -> Primitive<ReturnType<Member.prototype.toJSON>>
let members: Primitive<Member[]> = JSON.parse(json);
// Date -> string throw Date.toJSON()
console.log(members[0].login_histories[0].timestamp);
}
type Primitive<Member[]> = Array<{ id: number; // Number -> number name: string; email: string; // String -> string mobile: string; login_histories: Array<{ timestamp: string; // Date.toJSON(): string success: boolean; // Boolean -> boolean }>; }>;
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No repository files, tests, or entry points are named. Start by reviewing the TypeScript type-checker design relevant to recursive conditional and mapped types, then determine whether the proposed Primitive helper has an accepted scope and testable semantics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100