microsoft / microsoft/TypeScript
Remove name assignment when renaming a renamed destructured property to its original name
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Search Terms
rename, destructuring
Suggestion
When renaming a variable, which comes from an object destructuring and is assigned with another name, back to its original name, the name assignment is not removed, and becomes a little extra and useless code. It would make the code cleaner if the assignment can be removed when rename is done.
Use Cases
To have cleaner code.
Examples
const obj = { a: 1 };
const { a: b } = obj;
console.log(b);
Renaming b to a:
Now (at least up to 3.6.3):
const { a: a } = obj;
console.log(a);
Better:
const { a } = obj;
console.log(a);
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the TypeScript example by renaming b to a in the destructuring declaration; the issue names no implementation file, test, or entry point. Trace the rename behavior and add coverage showing that { a: a } becomes { a }, while other rename cases retain their assignments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100