microsoft / microsoft/TypeScript

Sorting an array removes type inference

Open
#34,099 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Domain: check: Type Inference
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.7.0-dev.20191011

Search Terms: type inference

Code

function getAllValuesUnsorted(m: ReadonlyArray<ReadonlyArray<string>>): ReadonlyArray<string> {
	// OK
	return Array.from(flatten(m.values()))
}

function getAllValuesSorted(m: ReadonlyArray<ReadonlyArray<string>>): ReadonlyArray<string> {
	// Type 'unknown[]' is not assignable to type 'readonly string[]'.
	return Array.from(flatten(m.values())).sort()
}

function* flatten<T>(a: Iterable<Iterable<T>>): Iterable<T> {
	for (const xs of a)
		for (const x of xs)
			yield x
}

Expected behavior:

No error.

Actual behavior:

a.ts:6:2 - error TS2322: Type 'unknown[]' is not assignable to type 'readonly string[]'.
  Type 'unknown' is not assignable to type 'string'.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the TypeScript compiler's type inference and generic array method handling, using the reproducer in the issue as the first test case. Investigate why adding sort() changes the inferred result from string[] to unknown[], then add a regression test that accepts the sorted expression without an error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.