microsoft / microsoft/TypeScript

TS3.6 regression: Map constructor overloads

Open
#33,611 0 comments 8 reactions 1 assignee View on GitHub

@rbuckton is already working on this.

Since Sep 26, 2019.

Needs Investigation
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.7.0-dev.20190917

Search Terms: Map constructor overload array concatenation

Code

const M1 = new Map([
  ['k', {a: 1, b: 'asd'}],
  ['k', {a: 2, b: 'asd'}],
]);

const M2 = new Map([
  ...M1,
  ['k', {a: 1}],
]);

Expected behavior:

Success, constructs a const M2: Map<string, {a: number;}>.

Actual behavior:

input.ts(6,20): error TS2769: No overload matches this call.
  The last overload gave the following error.
    Argument of type '([string, { a: number; b: string; }] | [string, { a: number; }])[]' is not assignable to parameter of type 'readonly (readonly [string, { a: number; b: string; }])[]'.
      Type '[string, { a: number; b: string; }] | [string, { a: number; }]' is not assignable to type 'readonly [string, { a: number; b: string; }]'.
        Type '[string, { a: number; }]' is not assignable to type 'readonly [string, { a: number; b: string; }]'.
          Types of property '1' are incompatible.
            Property 'b' is missing in type '{ a: number; }' but required in type '{ a: number; b: string; }'.

Playground Link:
https://www.typescriptlang.org/play/#code/MYewdgzgLgBAsgRhgXhmApgd3gQwA4AUA2gFAwxEDkA1pQDQwDeOAXDAgwEZuU4QAmlAL4BdOmQo16TVjABMXHn0GjxIgJQBuEiVCRYcOSjRZchUuQB01xOPJVaDZmwSqSGkkA

Related Issues:

None found.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.