microsoft / microsoft/TypeScript
Abstract classes will still import the value for a computed property at runtime
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 3.7.0-dev.20190920
abstract class import computed property
abstract class computed property imports for runtime
Code
sharedSymbol.ts
export const sharedSymbol: unique symbol = Symbol();
AbstractClass.ts
import { sharedSymbol } from "./sharedSymbol";
abstract class AbstractClass {
public abstract [sharedSymbol]: string;
}
Expected behavior:
sharedSymbol.js is not imported by AbstractClass.js
Actual behavior:
The symbol is imported by AbstractClass.js despite it's use being omitted due to it's abstract nature
Playground Link: Unavailable due to the bug being related to imported values.
Related Issues: No, I did not find any
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with sharedSymbol.ts and AbstractClass.ts, then inspect the emitted AbstractClass.js and the compiler path handling abstract computed properties. Add a regression test for the imported value and verify that the emitted JavaScript no longer imports sharedSymbol.js.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100