microsoft / microsoft/TypeScript

Detect exotic assignment patterns to JS prototypes

Open
#33,454 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Template added by by @mjbvz

TS Versions: 3.7-20190911

Repo
For the JS:

function A() {}

A.prototype.foo = 1;

[A.prototype.bar] = [2],
{baz: A.prototype.baz} = {baz: 3};

const proto = A.prototype;
proto.prop = 4;

Expected
Intellisense for instances of A should show four properties

Actual
Only foo shown.

Original report below

Intellisense seems to only recognize straightforward prototype property definitions like Class.prototype.prop = value.

Assigning Class.prototype to a variable and extending that, or using destructuring syntax will not be recognized by it:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the JavaScript snippet in TypeScript IntelliSense and confirm that only foo appears on A instances. No implementation file or test is named, so trace the language-service/type-checker handling of prototype assignments, aliases, and destructuring. Done means all four properties appear in IntelliSense.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.