microsoft / microsoft/TypeScript
Error on static class members named 'constructor' should be consistent
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 3.7.0-dev.20190831
Search Terms: class, constructor, static, computed, quoted
Code
class A { static constructor() {} }
class B { static "constructor"() {} }
class C { static ["constructor"]() {} }
Expected behavior:
Even though it may be confused with non-standard extensions like #265, I think treating all cases equally would be less confusing, because unlike non-static ["constructor"] there is no difference at runtime.
Actual behavior:
A and B (with #31949) get a 'static' modifier cannot appear on a constructor declaration.
diagnostic.
Playground Link:
http://www.typescriptlang.org/play/#code/MYGwhgzhAECC0G9oQC5hQS2NYB7AdqgE4CuwKuRAFAJSIC+09AUKJDAEKLJqbYBEeQilLlK-WgyatwUaAGFuqdFmgBtQQWJkKRfgF1JCRiyA
Related Issues: #31020, https://github.com/eslint/eslint/pull/12110
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the A, B, and C examples in the linked TypeScript Playground and compare their diagnostics. Read the behavior described in related issue #31949, then trace the compiler handling for static members named constructor; done means the three forms receive consistent treatment as described in Expected behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100