noImplicitThis codefix should account for static functions

Search Terms

codefix static this noImplicitThis

Suggestion

If a function is used as the initializer of a static property declaration, should the type of its this added by the --noImplicitThis codefix include typeof?

See discussion in #31138.

Use Cases

Static methods are arguably more likely to be called with the static class as their this scope in common practice. This would more accurately reflect that behavior.

Examples

const returnThisMember = function ([| |]) {
    return this.member;
}

class Container {
    member = "sample";
    static returnThisMember = returnThisMember;
};

Right now [| |] just becomes this: Container.

Checklist

My suggestion meets these guidelines:

• This wouldn't be a breaking change in existing TypeScript/JavaScript code
• This wouldn't change the runtime behavior of existing JavaScript code
• This could be implemented without emitting different JS based on the types of the expressions
• This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
• This feature would agree with the rest of TypeScript's Design Goals.

Start with the noImplicitThis codefix and the discussion in #31138, then trace how a function used as a static property initializer receives its this type. Use the Container example to verify that the suggested type accounts for the static class scope, including typeof where appropriate.