microsoft / microsoft/TypeScript

Add new `sourceRootDir` setting

Open
#31,873 21 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.5.1

Search Terms: sourceRoot, sources, sourcemap

Code

  1. Create a module like: src/nested/foo.ts

  2. Use the following tsconfig.json with tsc:

{
  "include": ["src"],
  "compilerOptions": {
    "baseUrl": ".",
    "outDir": "dist",
    "sourceMap": true,
    "sourceRoot": "src"
  }
}

Expected behavior:

Inside nested/foo.js.map, the sourceRoot should be ../src/ instead of src/. Otherwise, the paths in the sources array cannot be found.

Actual behavior:

The sourceRoot is src/ regardless of nesting.

Playground Link: N/A

Related Issues: None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with TypeScript 3.5.1 or typescript@next using the provided tsconfig.json and the nested src/nested/foo.ts module. Inspect the generated nested/foo.js.map and sourcemap generation path; done when a sourceRootDir setting produces a sourceRoot of ../src/ for nested output so the sources resolve correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.