microsoft / microsoft/TypeScript

Suggestion: extract to function expression

Open
#31,860 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Search Terms

function expression declaration extract method refactoring code fixes

Suggestion

"Extract to function" is very useful, but it only supports generating function declarations. Some people (such as me) prefer to use function expressions instead of declarations.

For example:

const fn = () => {
    const foo = 1;
    const bar = foo + 2
}

If I select line 3 and extract to function, I get

const fn = () => {
    const foo = 1;
    const bar = newFunction(foo)
}

function newFunction(foo: number) {
    return foo + 2;
}

I want:

const newFunction = (foo: number) => foo + 2;

const fn = () => {
    const foo = 1;
    const bar = newFunction(foo)
}

Some ideas:

  • An option to toggle between expressions/declarations
  • Separate refactorings for both expressions and declarations

Use Cases

Examples

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named in the issue; start by locating the existing “Extract to function” refactoring entry point and its tests. Compare the requested function-expression output with current declaration behavior, then determine whether a toggle or separate refactoring is the intended completion criterion and cover both TypeScript and JavaScript cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.