microsoft / microsoft/TypeScript

Property initialisation check in TS 3.5 is too strict for ember 3.5

Open
#31,682 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

In Discussion Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Start reading here: https://github.com/microsoft/TypeScript/pull/29395#issuecomment-497376445

import Component from '@ember/component';
import defaultTo from 'lodash/default-to';

export default class Welcome extends Component {
  greeting: string = defaultTo(this.greeting, "Hello");
}

Briefly, ember 3.5's Components have properties that are initialised by the base to a value, but Typescript doesn't know about this. Users should be able to squash the error by writing greeting!: string = ..., or by turning off strictPropertyInitialization, but can't today.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked TypeScript pull request and reproduce the Ember 3.5 example using the TypeScript 3.5 property-initialisation check. Compare the behavior of the shown declaration with the proposed greeting! form, then identify the relevant compiler entry point and regression coverage; done means the intended valid form no longer reports the error without weakening unrelated checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.