microsoft / microsoft/TypeScript
Issue a better error message when trying to use a modifier outside of a mapped type
Open
Nobody has claimed this yet.
Experience Enhancement
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 3.4.0-dev.201xxxxx
Search Terms:
Code
export type ITSReadonlyToWriteableArray<T extends readonly any[]> = Omit<T, keyof any[]> &
ITSUnpackedArrayLike<T>[] & {
-readonly [P in number | 'length']: T[P]
};
export type ITSWriteableArray<T extends readonly any[]> = Omit<T, 'length' | number> & {
-readonly length: number
}
// => here is error
Expected behavior:
no error, more better error message
Actual behavior:
Error:(96, 12) TS1005: '[' expected.
and a small ask (don't need care this Quesion)
Q: how to list all readonly key
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start from the TypeScript code in the issue and reproduce the TS1005 error with the shown mapped-type modifier examples. Trace the parser or diagnostic entry point responsible for the '[' expected message; done means invalid modifier placement produces a clearer error message without incorrectly rejecting valid mapped types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100