microsoft / microsoft/TypeScript

[k in keyof EnumA] should show error

Open
#31,620 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

In Discussion Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.4.0-dev.201xxxxx

Search Terms:

Code

export const enum EnumA
{
	a,
	b,
}

export type Interface = {
	[k in keyof EnumA]: (a: number, b: string) => void
	// here should show error or a warn message, because it is enum
}

let a: Interface = {
	a(a, b)
	{
		console.log(a.toFixed(), b.blink());
	},
	b(a, b)
	{
		console.log(a.toFixed(), b.blink());
	},
}

Expected behavior:

error or a warn message, and tell use [k in keyof typeof EnumA]

Actual behavior:

no error

Playground Link:

Related Issues:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue's TypeScript code with the reported 3.4.0-dev version and a current compiler, then investigate mapped types using keyof on an enum. Done means the compiler behavior matches the issue's requested diagnostic or the expected behavior is clarified by the existing type-checking rules.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.