microsoft / microsoft/TypeScript
make @ts-ignore available when using {/* @ts-ignore */}.
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Search Terms
@ts-ignore annotation
Suggestion
Hi, I apologize if it is already discussed. However, I believe we need this feature for @ts-ignore.
Currently @ts-ignore only mutes the errors only using with // @ts-ignore.
I believe we also need to make @ts-ignore available when using {/* @ts-ignore */}.
I've already founded this issue. It's a similar issue but not the same and I think this is easier to implement.
I think this feature only need to change this code.
https://github.com/Microsoft/TypeScript/blob/master/src/compiler/program.ts#L2
Use Cases
I'd like to use this in the html structures in the TSX file.
Examples
This is implementation for amp-script. We have to use onclick instead of onClick and it's not supported for now.
const App = () => {
return (
<div>
...
{/* @ts-ignore */}
<button onclick={() => setCount(count + 1)}>Click me</button> // this line should be ignored
...
</div>
);
}
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue points to src/compiler/program.ts; start there and trace how // @ts-ignore comments are recognized for TSX. Confirm the requested behavior with the provided TSX example and ensure existing comment behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100