microsoft / microsoft/TypeScript
KeyboardEvent interface implements key as string
Open
Nobody has claimed this yet.
Domain: lib.d.ts
Needs Proposal
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 3.3.1
Search Terms:
Actual Output
The key property is defined as a string
Expected Output
The key property should be a enum of keys.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue identifies the KeyboardEvent interface and its key property; start by locating that declaration in TypeScript's DOM library definitions and reviewing how the current type is sourced. Determine the intended key set, then verify the declaration and relevant tests reflect it; done means key is no longer typed as a plain string.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100