microsoft / microsoft/TypeScript

Convert to destructed refactoring not enabled in JavaScript?

Open
#30,764 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Domain: JavaScript Domain: LS: Refactorings In Discussion Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.5.0-dev.20190404

Search Terms:

  • refactor / refactoring
  • convert to destructed parameters

Code
For a simple js file

function doStuff(a, b, c) {
    return a + b + c;
}

doStuff('a', 'b', 1);
doStuff('x', 'y', 2);

Expected behavior:
A convert to restructured refactoring is available on doStuff

Actual behavior:
I'm not seeing any such refactoring show up in js files

Playground Link:

Related Issues:

  • #23552

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the TypeScript language-service refactoring implementation and compare JavaScript support with the existing behavior referenced by issue #23552. Reproduce the example in a JavaScript file and determine whether the requested destructuring refactoring is expected to appear; done means the refactoring is available there and covered by an appropriate test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
developer-experience, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.