microsoft / microsoft/TypeScript
Convert to async/await doesn't support .finally() method
Open
Nobody has claimed this yet.
Experience Enhancement
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
declare function delay(n: number): Promise<void>;
async function foo() {
delay().then(x => delay(400)).then(x => delay(400)).finally(x => console.log(x));
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the TypeScript example in the issue, then trace the convert-to-async/await refactoring for Promise chains ending in finally. Done means the example converts successfully while preserving the finally callback; no source file or test is named in the report.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100