microsoft / microsoft/TypeScript

feature request: change indentation of multi-line variable declarations

Open
#30,322 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Search Terms

format code indent tsserver

Suggestion

When tsserver formats the following typescript code using an indent size of 2, I get

let a = 1,
  b = 2

while I'd expect it to indent the code like

let a = 1,
    b = 2

regardless of the indent size.

Additionally, the following code would be formatted like

const a = 1,
      b = 2

Use Cases

This feature would be useful in variable declarations (let, var, const) when using an indent size different than 4.

Examples

See the Suggestion section above.

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by investigating the tsserver formatting path for multi-line let, var, and const declarations, using the examples in the Suggestion section as expected output. Identify the formatter tests covering indentation and add cases for indent sizes other than 4; done means these declarations consistently use the requested continuation indentation without changing runtime behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.