microsoft / microsoft/TypeScript
Boolean["toString"] inconsistency
Open
Nobody has claimed this yet.
In Discussion
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 3.4.0-dev.20190305
Code
const key: keyof Boolean = "toString"; // error - "toString" is not assignable to "valueOf"
const x: {toString(): string} = new Boolean(); // no error
const y: Boolean["toString"] = true.toString; // no error
class Bool extends Boolean {
protected toString() { // also no error, but should be
return "";
}
}
Expected behavior:
keyof Boolean should be "toString" | "valueOf"
Playground
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No repository file or test is named. Reproduce the Boolean and keyof examples in the linked Playground, then trace the compiler behavior involved in Boolean members and protected overrides. Done means keyof Boolean includes both "toString" and "valueOf", while the shown assignments and override are checked consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100