microsoft / microsoft/TypeScript
Emit Numerical Literal with different TokenFlags
Open
Nobody has claimed this yet.
Awaiting More Feedback
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Search Terms
emitter, numerical
Suggestion
Currently, all Numerical Literal has been emitted as Decimal number.
Hope to allow emit Hex Literal or Binary Literal etc
Use Cases
ts.createLiteral('2', TokenFlags.BinarySpecifier) // 0b10
That is useful to create a codegen
Examples
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementation and uses of ts.createLiteral and TokenFlags, then review the related pull request linked in the issue. Determine how numerical literals are currently emitted and what API and emitter changes are needed. Done means requested binary, hexadecimal, or other literal flags produce the intended source form without changing existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100