microsoft / microsoft/TypeScript
Incorrect type for `ClassDecorator`
Open
Nobody has claimed this yet.
Experience Enhancement
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
The current (3.2.2) type for class decorator function seems to be incomplete:
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
It says that target should extend a Function, but it should be something like NewableFunction I guess, since its a class constructor and it can be passed to new.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the ClassDecorator declaration in TypeScript's standard library type definitions and compare its target parameter with the constructor type expected for class decorators. Check the existing type-checking coverage for decorators, then confirm that the corrected declaration accepts valid class constructors and rejects inappropriate targets.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100