microsoft / microsoft/TypeScript
Relations based on variance markers do not take into account parameters used as key types.
Open
@ahejlsberg is already working on this.
Since Feb 5, 2019.
Bug
Domain: check: Variance Relationships
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 3.3
Code
type Record2<K extends keyof any, T> = {
[P in K]: T;
};
function defaultRecord(x: Record<'a', string>, y: Record<string, string>) {
x = y; // no error, but error expected.
}
function customRecord(x: Record2<'a', string>, y: Record2<string, string>) {
x = y; // no error, but error expected.
}
function mixed1(x: Record2<'a', string>, y: Record<string, string>) {
x = y; // error
}
function mixed2(x: Record<'a', string>, y: Record2<string, string>) {
x = y; // error
}
Playground Link: link
Related Issues: #28798
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.