microsoft / microsoft/TypeScript

Parameter hints do not get dismissed when the cursor moves

Open
#29,430 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Domain: LS: Signature Help Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Presently, it appears that the parameter hint window does not get dismissed if it is brought up when invoking a function within the argument list of another function and you move out of the inner function's argument list. The popup changes to reflect its new position, but this is not a generally useful thing and in something like a giant argument list like a call to webpackMerge this is incredibly irritating. Couple this with the fact that the Vim extension does not dismiss the param hints when you press escape and it's pretty rough.

It would be really nice if the parameter hints were dismissed when leaving the current argument list. I can see an argument for it remaining open while navigating around the current argument list, but if the cursor leaves that list and goes to an outer list, it should be dismissed.

Thanks!

  • VSCode Version: 1.27.0 - insiders and 1.26.0
  • OS Version: macOS 10.13.6

Steps to Reproduce:

  1. Open a new file

  2. Change to javascript mode

  3. Enter the text:

    const path = require('path')
    
    Array.isArray([
      baz,
    
    ])
    
  4. Place cursor on line after baz

  5. Type Array.apply(. The parameter hint overlay should appear.

  6. Press the up arrow.

Expected:
Parameter hint window is dismissed

Actual:
Parameter hint window remains covering code

Does this issue occur when all extensions are disabled?: Yes

parameterhints

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by reproducing the JavaScript example in VS Code, including moving the cursor out of the inner argument list; done means the parameter hint window is dismissed when leaving that list and the reported behavior is covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, vscode
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.