microsoft / microsoft/TypeScript

Object.assign({}) seems to always return a type any

Open
#29,348 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Domain: lib.d.ts
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.3.0-dev.20190110

Search Terms: Object.assign

Code

function foo(): {foo: string} {
    return Object.assign({});
}

Interestingly the code:

function bar(): {bar: string} {
    return Object.assign({}, {bar: 1});
}

does report the expected error

Expected behavior: TypeScript should report an error because the type returned by return Object.assign({}); does not mach {foo: string} but instead the type any is assumed.

Actual behavior: No error is shown

Playground Link: https://www.typescriptlang.org/play/index.html#src=function%20foo()%3A%20%7Bfoo%3A%20string%7D%20%7B%0D%0A%20%20%20%20return%20Object.assign(%7B%7D)%3B%0D%0A%7D%0D%0A

Related Issues: no

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported Object.assign example in the linked TypeScript Playground using the issue's TypeScript version and current nightly build. Trace how the compiler types Object.assign({}) and add a regression test that verifies the return is rejected when it does not satisfy {foo: string}.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.