microsoft / microsoft/TypeScript
--noImplicitAny codefixes infer methods returning void instead of any
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 3.3.0-dev.20190108
Search Terms: noimplicitany infer code fix codefix quick suggested return void any
Code
function curryThrough(callback) {
return callback("turtle");
}
Expected behavior:
--noImplicitAny suggested fix on the callback parameter:
function curryThrough(callback: (arg0: string) => any) {
Actual behavior:
function curryThrough(callback: (arg0: string) => void) {
Related Issues: #13243 (parent tracking quick fixes)
void seems like an odd default choice for the unknown return value of a method. If the type can't be inferred from usage, shouldn't it be any?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the --noImplicitAny suggested fix with the curryThrough example and compare the inferred callback return type with the expected any result. Follow the noImplicitAny codefix entry point and related tracking issue #13243; done means the fix produces the expected callback type without regressing related quick fixes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100