microsoft / microsoft/TypeScript
Low readability when type casting by JSDoc
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Search Terms
jsdoc, type castSuggestion
Currently type casting by JSDoc is not pretty 1) because the comment must be after variable declaration 2) it requires parentheses (#18212).
// @ts-check
const img = /** @type {HTMLImageElement} */ (document.getElementById('#cat'))
img.src = 'cat.gif'
How about the JSDoc type declaration automatically casts the assigned type, only when the variable declaration has the value assigning part?
Use Cases
The code will be prettier: https://github.com/w3c/respec/pull/1949#discussion_r240971984
Examples
Current:
// @ts-check
/** @type {HTMLImageElement} */
const img = document.getElementById('#cat') // Error: Type 'Element' is not assignable to type 'HTMLImageElement'
img.src = 'cat.gif'
Suggestion:
// @ts-check
/** @type {HTMLImageElement} */
const img = document.getElementById('#cat') // Element being casted as HTMLImageElement
img.src = 'cat.gif'
/** @type {HTMLImageElement} */
let img2;
img2 = document.getElementById('#cat') // Still an error
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the proposed JSDoc casting examples and the referenced respec discussion. Compare the requested behavior for const declarations with the explicitly unchanged behavior for later assignments. Done means the proposal has an agreed implementation and verified type-checking behavior without changing emitted JavaScript.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100