microsoft / microsoft/TypeScript
Allow ignoring certain TS suggestion-level diagnostic codes
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Related to what was discussed in https://github.com/Microsoft/vscode/issues/61326.
Would provide more granularity to the settings introduced with https://github.com/Microsoft/vscode/pull/46590.
It might be useful to introduce a new setting to ignore certain suggestion diagnostic codes while still keeping suggestion diagnostics enabled, rather than having to disable them altogether.
What I'm proposing is to introduce 2 new settings, javascript.suggestionActions.ignoredCodes and typescript.suggestionActions.ignoredCodes. These would take a list of suggestion diagnostic codes that the user wants to ignore, given as a string of either comma- or space-separated code numbers.
Example:
{
// ...
"typescript.suggestionActions.enabled": true,
"typescript.suggestionActions.ignoredCodes": "7043, 80006"
// ...
}
This list would only be checked when a suggestion-level diagnostic is received, so including non-suggestion-level diagnostic codes in the list would have no effect (errors and messages would not be ignored).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the related VS Code issue #61326 and pull request #46590, then trace how suggestion-level diagnostics and the existing suggestionActions settings are handled. Done means the proposed JavaScript and TypeScript ignored-code settings accept comma- or space-separated codes and affect only suggestion-level diagnostics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 28/100