microsoft / microsoft/TypeScript
chained generic mixins fail
Open
Nobody has claimed this yet.
In Discussion
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 3.2.0-dev.201xxxxx
Search Terms: chained generic mixins
Code
type Constructor<T> = new(...args: any[]) => T;
interface XInterface {
value: string;
}
function make<T extends Constructor<any>>(Base: T) {
return class extends Base implements XInterface {
value = "Hello!"
}
}
// Great. Works.
class _X1 extends make(Function) { hello() { this.value; }}
type _T1 = Constructor<HTMLElement>;
// Oops. But changing `make(Base)`, to `make(Base as _T1)` works perfectly,
// which makes no sense.
function make2<T extends _T1>(Base: T) {
return class extends make(Base) { }
}
Expected behavior:
Compile.
Actual behavior:
Type '{ new (...args: any[]): make.(Anonymous class); prototype: make.(Anonymous class); } & T' is not a constructor function type.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the supplied chained generic mixin example with the reported TypeScript 3.2.0-dev version, then compare it with the variant using Base as _T1. Trace the compiler's handling of the returned constructor type; done means the original example compiles without the reported error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100