microsoft / microsoft/TypeScript
Suggestion and codefix to add missing cases to switch
Open
Nobody has claimed this yet.
Domain: LS: Quick Fixes
In Discussion
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 3.2.0-dev.20181106
Code
enum E { A, B, C }
function f(x: E) {
switch (x) {
case E.A: return "a";
case E.C: return "c";
}
}
Expected behavior:
Suggestion on x recommending to add a case case E.B:, and a codefix which does that (perhaps by adding case E.B: throw new Error("todo");).
Actual behavior:
No suggestion.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the TypeScript enum and switch reproduction in the issue and trace how suggestions and codefixes are implemented for switch statements. Add the missing-enum-case suggestion and corresponding codefix, then verify the reported example through the compiler's existing test setup; the issue does not name specific files or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100