microsoft / microsoft/TypeScript

infer-from-usage codefix should mark parameters as optional

Open
#28,377 1 comment 0 reactions 1 assignee View on GitHub

@sandersn is already working on this.

Since Nov 6, 2018.

Domain: LS: Quick Fixes In Discussion Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Search Terms

codefix infer from usage optional parameter

Suggestion

When you ask to for the infer-from-usage codefix for f:

function f(x, y) {
  return x + (y || 0)
}
f(1)

You should get function f(x: number, y?: number | undefined)

This already works in JS. You get /** @param {number | undefined} [y] */.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.