microsoft / microsoft/TypeScript

Declaration file emitted with esModuleInterop can't be consumed without it

Open
#28,009 3 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Domain: Declaration Emit Experience Enhancement Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.2.0-dev.20181019

Search Terms:

Code

import abs from "abs"; // using @types/abs which uses `export =`
export const x: typeof abs = <any>null;

Expected behavior:

Output .d.ts is:

import abs = require("abs");
export declare const x: typeof abs;

Actual behavior:

import abs from "abs";
export declare const x: typeof abs;

Discovered in quill on DefinitelyTyped, which imports from quill-delta, which is written in TypeScript with esModuleInterop.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the TypeScript code in the report and compare the emitted .d.ts under esModuleInterop with a consumer that does not enable it. Trace declaration emission for the default import from the @types/abs package; done when the generated declaration is consumable without esModuleInterop and preserves the expected require-style import.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.