microsoft / microsoft/TypeScript

Using generic argument that extends something, stops inferring super keys when Exclude is used in addition to keyof and Pick

Open
#27,928 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Domain: Conditional Types Needs Proposal Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.1.0

Search Terms:
keyof extends pick exclude

Code

interface Base {
    base1: number;
    base2: number;
}

class Data<T extends Base> {
   alpha(k:keyof Pick<T, Exclude<keyof T, "base1">>) {   }
    beta(k:keyof Pick<T, keyof T>) {   }
}

function wrapped<T extends Base>() {
    let d = new Data<T>();
    d.alpha("base2"); // Argument of type '"base2"' is not assignable to parameter of type 'Exclude<keyof T, "base1">'. 
    d.beta("base2");  // works
}

Expected behavior:

Both alpha and beta should work.

Actual behavior:

Alpha does not work: ` Argument of type '"base2"' is not assignable to parameter of type 'Exclude<keyof T, "base1">'.

Playground Link:

Playground link

Related Issues:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the generic keyof/Pick/Exclude example in the linked TypeScript Playground, using the reported TypeScript version or typescript@next. Trace the type-checking behavior for alpha and beta; the fix is complete when alpha accepts "base2" without an error while beta continues to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.