microsoft / microsoft/TypeScript
Suggestion diagnostics show in untyped JS code when regular diagnostics don't
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 3.2.0-dev.20181011
Code
"".toUperKase();
const b = require("./b");
Expected behavior:
If we're not showing regular diagnostics, we should probably not show any suggestions either.
Actual behavior:
"".toUperKase() is fine. require is a real problem that we need to let the user know about right away!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the behavior with the TypeScript snippet in the issue, comparing untyped JavaScript diagnostics with suggestion diagnostics. Trace the compiler's handling of regular and suggestion diagnostics; done means the misspelled method is not reported as a suggestion when regular diagnostics are hidden, while the require problem remains visible.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100