microsoft / microsoft/TypeScript

Show signature help when overriding/implementing method

Open
#26,023 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Domain: LS: Signature Help Experience Enhancement Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.1.0-dev.20180727

Code

class A {
    m(n: number): void {}
}
class B extends A {
    m(/**/)
}

Expected behavior:

Get signature help for m(n: number): void. Extension of #26022.

Actual behavior:

No signature help.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the TypeScript snippet in an editor and trace the signature-help handling at the m(/**/) position when the method overrides a base-class method. Compare it with signature help for the inherited method and verify that m(n: number): void is shown.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.