microsoft / microsoft/TypeScript

Improve completions with --checkJs turned off

Open
#25,931 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Domain: LS: Completion Lists Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.1.0-dev.20180725

Code

/**
 * @typedef {object} I
 * @property {number} m
 */

/** @returns {I} */
function f() { return { x: 0 }; }
const x = f();
x.

Expected behavior:

Get completion for m only.

Actual behavior:

Get completions for I, f, and x. None of which are properties.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the provided JSDoc example with TypeScript 3.1.0-dev.20180725 and checkJs disabled, then trace the language-service completion entry point for x.. Done means the completion list contains only the declared property m, rather than I, f, and x.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.