microsoft / microsoft/TypeScript
simply logic predicate code fix or suggestion
Open
Nobody has claimed this yet.
Domain: LS: Refactorings
Help Wanted
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Search Terms
logic, predicate, quickfix
Suggestion
provide a code fix or refactor to simply logic predicate
Use Cases
simply some complexity logic predicate is hard and always get a break change,
hope have a code fix to simply that like the jetbrain idea
Examples
if (! a && !b || !a && !c) {
// something
}
fix to:
if (!(a && (b || c))) {
// something
}
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript / JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. new expression-level syntax)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Start by reviewing the predicate example and the requested simplification, then determine the intended scope and behavior for a TypeScript code fix or refactor suggestion. Done means the behavior is clearly specified and covered by appropriate language-service tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100