microsoft / microsoft/TypeScript
Add related error spans for getter/setters with different types
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Now that we support multiple related spans for errors (#10489, #22789, #24548), we'd like to improve an existing error message.
Currently, we provide a diagnostic for a pair of get/set accessor's types not matching:
Code:
let x = {
get foo() { return 100; }
set foo(value: string): { }
}
Current error:
'get' and 'set' accessor must have the same type.
We'd like to give a better error message. For example:
Primary span:
A 'get-' and 'set-' accessor must have the same type, but this 'get' accessor has the type '{0}'.
Related span:
The respective 'set' accessor has the type '{0}'.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests; start by locating the TypeScript typechecker diagnostic for mismatched get/set accessor types and tracing its diagnostic-span handling. Done means the primary diagnostic reports the getter type, a related span reports the setter type, and coverage verifies the displayed messages and spans.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100