microsoft / microsoft/TypeScript
strictNullChecks false positives in case clause
Open
Nobody has claimed this yet.
Bug
Domain: check: Control Flow
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 2.9.0-dev.20180512
Search Terms:
Code
// @strictNullChecks: true
function test1(param?: {prop: string}) {
switch (param && param.prop) {
case 'foo':
return param.prop; // error: 'param' is possibly undefined
}
}
function test2(param: {prop?: string}) {
switch (param && param.prop) {
case 'foo':
return param.prop.charAt(0); // error: 'param.prop' is possibly undefined
}
}
Expected behavior:
Compiles without error.
Actual behavior:
strictNullChecks errors as described in the comments above.
Related Issues:
#23818
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the supplied switch examples and the linked Playground reproduction, then compare the behavior with related issue #23818. Investigate how strictNullChecks narrows values in case clauses. Done means both examples compile without the reported possibly-undefined errors while preserving correct narrowing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100