microsoft / microsoft/TypeScript
Don't offer to change spelling to not-yet-defined variables
Open
Nobody has claimed this yet.
Awaiting More Feedback
Domain: LS: Quick Fixes
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 2.8.1
Search Terms: suggest change spelling auto fix import
Code
// This import is missing, but can be auto-suggested
import { /* SomeClass */ } from "./SomeClass";
const bindContainer = (container) => {
const someClass = container.get(SomeClass);
};
Expected behavior:
When I ask for auto-fixes on the SomeClass, it should only suggest to add it to the import declaration.
Actual behavior:
Two suggestions are given:
Change spelling to 'someClass'Add 'SomeClass' to existing import declaration from "./SomeClass"
We can statically reject the rename suggestion here because this is in the initializer of the variable.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the TypeScript 2.8.1 example and requesting auto-fixes on SomeClass. Trace the logic that offers spelling changes and the existing-import suggestion, then verify that the spelling suggestion is omitted while the import suggestion remains.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100