microsoft / microsoft/TypeScript
Organize imports should remove blank lines within imports
Open
Nobody has claimed this yet.
Awaiting More Feedback
Domain: LS: Organize Imports
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 2.9.0-dev.20190327
Search Terms:
- Organize imports
Code
- For the js:
import { x } from 'x';
import { y } from 'y';
console.log(x, y)
- Run organize imports.
Expected behavior:
Blank lines within the import are removed
import { x } from 'x';
import { y } from 'y';
console.log(x, y)
Actual behavior:
Blanklines preserved but shifted to end of imports:
import { x } from 'x';
import { y } from 'y';
console.log(x, y)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue's TypeScript 2.9 organize-imports example with blank lines between imports, then locate the organize-imports entry point and its existing tests. Done means the blank lines between imports are removed without moving them to the end, and the behavior is covered by a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100