microsoft / microsoft/TypeScript
In JS, aliasing of C.prototype should cause property assignments to add to the instance
Open
Nobody has claimed this yet.
checkJs
Domain: JavaScript
Needs Proposal
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
// from acorn
function Parser() {
/** @type {number} */
this.x = 1
}
var pp = Parser.prototype
pp.m = function () {
this.x = "should be an error"
return this.x
}
new Parser().m
Expected behavior:
pp.m = function() ... should add a method to the Parser instance. This should result in:
- Error: can't assign string to property x of type number
- No error on
new Parser().m
Actual behavior:
No error on this.x = "should be an error" and an error on new Parser().m
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the provided JavaScript/TypeScript example and trace how the checker handles the aliased Parser.prototype, assignments to this.x, and new Parser().m. Done means the example reports the string assignment as an error while accepting the method access on the new instance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100