microsoft / microsoft/TypeScript
this any typed in some JS object literals
Open
Nobody has claimed this yet.
Bug
Domain: JavaScript
Has Repro
VS Code Tracked
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
From https://github.com/Microsoft/vscode/issues/43930
TypeScript Version: 2.8.0.insiders-20180211
Search Terms:
- this
- object literal
Code
For the js:
console.log({
a: 1,
b() {
this
}
});
Hover over this in b
Bug
this has any type
this is properly typed in cases like:
const z = {
a: 1,
b() {
this
}
}
Playground Link:
Related Issues:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the supplied JavaScript object-literal example in the TypeScript Playground or compiler tests and compare it with the const z example. Trace the JavaScript type-checking path for method this typing, using related issue #11072 for context; done means this receives the object-literal type in the reported case without regressing the working case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100