microsoft / microsoft/TypeScript

Formatter: Place JSX closing tag on new line

Open
#21,124 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Domain: Formatter Help Wanted Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 2.7.0-dev.20180108

Code

<div>
    wat</div>

Expected behavior:

<div>
    wat
</div>

Actual behavior:

No changes are made by the formatter.

Related:

While not directly related, I came across this while working on a fix for #20766. I can work on a fix for this issue as well.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the formatter behavior with the supplied JSX snippet and inspect the formatter path that handles JSX closing tags. Compare the unchanged output with the expected output, then verify that formatting places the closing tag on its own line without changing unrelated content.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.